New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Adapter ZEDO #2872

Merged

snapwich merged 11 commits into prebid:master from skazedo:master

Jul 23, 2018

Contributor

skazedo commented Jul 20, 2018

Type of change

Bugfix
Feature
[X ] New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other

Description of change

test parameters for validating bids

{
  bidder: 'zedo',
  params: {
    code: 2264004118
    dimId: 9
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

contact email of the adapter’s maintainer: prebidsupport@zedo.com
[X ] official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

skazedo added 9 commits

July 12, 2018 16:09


          initial commit

418baed


          updated contact and tag details

4381ccd


          changes ti support the renderers

cd09dbc


          Merge remote-tracking branch 'upstream/master'

66892e6


          changes to pass dimId

f134156


          fixed names of internal mapping

c5293b7


          Merge remote-tracking branch 'upstream/master'

c9e5aca


          Merge remote-tracking branch 'upstream/master'

ed1562f


          added comment

bf996ec

jsnellbaker requested a review from snapwich

July 20, 2018 16:00

jsnellbaker assigned snapwich

jsnellbaker added the needs review label

jsnellbaker mentioned this pull request

Added doc for ZEDO prebid/prebid.github.io#899

Merged

snapwich requested changes

View reviewed changes

Collaborator

snapwich left a comment

The code looks okay, but it's missing code to handle the GDPR string for the auction request and syncs.

skazedo added 2 commits

July 23, 2018 11:10


          Merge remote-tracking branch 'upstream/master'

b9efb20


          added gdpr param to request and other fixes

c768fe5

Contributor Author

skazedo commented Jul 23, 2018

@snapwich, I have commited changes to pass the gdpr consent in the request and sync .

snapwich approved these changes

View reviewed changes

Collaborator

snapwich left a comment

LGTM

snapwich merged commit 8eedfc3 into prebid:master

mkendall07 added a commit that referenced this pull request


          Revert "New Adapter ZEDO (#2872)"

bf9d79e

This reverts commit 8eedfc3.

snapwich pushed a commit that referenced this pull request


          Revert "don't allow null or undefined bid properties" (#2886)

50a9142

* Revert "New Adapter ZEDO (#2872)"

This reverts commit 8eedfc3.

* Revert "don't allow null or undefined bid properties (#2865)"

This reverts commit f5170d9.

florevallatmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request


          New Adapter ZEDO (prebid#2872)

cc5a8a8

* initial commit

* updated contact and tag details

* changes ti support the renderers

* changes to pass dimId

* fixed names of internal mapping

* added comment

* added gdpr param to request and other fixes

florevallatmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request


          Revert "don't allow null or undefined bid properties" (prebid#2886)

2cd6e27

* Revert "New Adapter ZEDO (prebid#2872)"

This reverts commit 8eedfc3.

* Revert "don't allow null or undefined bid properties (prebid#2865)"

This reverts commit f5170d9.

StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request


          New Adapter ZEDO (prebid#2872)

cfc9725

* initial commit

* updated contact and tag details

* changes ti support the renderers

* changes to pass dimId

* fixed names of internal mapping

* added comment

* added gdpr param to request and other fixes

StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this pull request


          Revert "don't allow null or undefined bid properties" (prebid#2886)

729854f

* Revert "New Adapter ZEDO (prebid#2872)"

This reverts commit 8eedfc3.

* Revert "don't allow null or undefined bid properties (prebid#2865)"

This reverts commit f5170d9.

ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request


          New Adapter ZEDO (prebid#2872)

25e64bf

* initial commit

* updated contact and tag details

* changes ti support the renderers

* changes to pass dimId

* fixed names of internal mapping

* added comment

* added gdpr param to request and other fixes

ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request


          Revert "don't allow null or undefined bid properties" (prebid#2886)

64f8c63

* Revert "New Adapter ZEDO (prebid#2872)"

This reverts commit 8eedfc3.

* Revert "don't allow null or undefined bid properties (prebid#2865)"

This reverts commit f5170d9.

AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request


          New Adapter ZEDO (prebid#2872)

398533d

* initial commit

* updated contact and tag details

* changes ti support the renderers

* changes to pass dimId

* fixed names of internal mapping

* added comment

* added gdpr param to request and other fixes

AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request


          Revert "don't allow null or undefined bid properties" (prebid#2886)

41fe26f

* Revert "New Adapter ZEDO (prebid#2872)"

This reverts commit 8eedfc3.

* Revert "don't allow null or undefined bid properties (prebid#2865)"

This reverts commit f5170d9.

AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request


          New Adapter ZEDO (prebid#2872)

1f5064e

* initial commit

* updated contact and tag details

* changes ti support the renderers

* changes to pass dimId

* fixed names of internal mapping

* added comment

* added gdpr param to request and other fixes

AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this pull request


          Revert "don't allow null or undefined bid properties" (prebid#2886)

42ac7be

* Revert "New Adapter ZEDO (prebid#2872)"

This reverts commit 8eedfc3.

* Revert "don't allow null or undefined bid properties (prebid#2865)"

This reverts commit f5170d9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels